From ab163ca5e6151ebb624546f519c9a695ff195e50 Mon Sep 17 00:00:00 2001 From: Barry Pederson Date: Sat, 12 Sep 2026 13:06:28 -0700 Subject: [PATCH] Fix clippy warnings in repository tests Use assert!/assert!(!..) instead of assert_eq! against literal bools, and drop a needless borrow. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01Kmrgkpp9YBJ6AMaWYPPZuD --- server/src/repository.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/server/src/repository.rs b/server/src/repository.rs index 3bf680a..dae65c2 100644 --- a/server/src/repository.rs +++ b/server/src/repository.rs @@ -127,7 +127,7 @@ mod tests { // echo -n "hunter2" | argon2 "$(openssl rand -base64 16)" -id let password_hash = "$argon2id$v=19$m=4096,t=3,p=1$VTMrc2wyaW93L01ibVFPOGNQcHcxQT09$UxX86sGpknkc45CnXq+4CZ0coiTYDvSWIN7JgbeAZUs"; - let parsed_hash = PasswordHash::new(&password_hash).unwrap(); + let parsed_hash = PasswordHash::new(password_hash).unwrap(); assert!( Argon2::default() .verify_password(password, &parsed_hash) @@ -141,7 +141,7 @@ mod tests { let request = Request::new("bp", "some-rad-password", "ignore-this", "also-ignore-this"); - assert_eq!(repository.check_auth(&request), true); + assert!(repository.check_auth(&request)); } #[test] @@ -150,7 +150,7 @@ mod tests { let request = Request::new("bp", "[id-1]hunter2", "ignore-this", "also-ignore-this"); - assert_eq!(repository.check_auth(&request), true); + assert!(repository.check_auth(&request)); } /// The key [id-1] is present in the test file, but the hash shouldn't match @@ -161,7 +161,7 @@ mod tests { let request = Request::new("bp", "[id-1]hunter-bad", "ignore-this", "also-ignore-this"); - assert_eq!(repository.check_auth(&request), false); + assert!(!repository.check_auth(&request)); } /// The key [id-2] is not present in the test file @@ -172,7 +172,7 @@ mod tests { let request = Request::new("bp", "[id-2]hunter", "ignore-this", "also-ignore-this"); - assert_eq!(repository.check_auth(&request), false); + assert!(!repository.check_auth(&request)); } #[test] @@ -181,7 +181,7 @@ mod tests { let request = Request::new("bp", "not-correct", "ignore-this", "also-ignore-this"); - assert_eq!(repository.check_auth(&request), false); + assert!(!repository.check_auth(&request)); } #[test] @@ -195,7 +195,7 @@ mod tests { "also-ignore-this", ); - assert_eq!(repository.check_auth(&request), false); + assert!(!repository.check_auth(&request)); } #[test] @@ -204,6 +204,6 @@ mod tests { let request = Request::new("bp-xxx", "commented-out", "ignore-this", "also-ignore-this"); - assert_eq!(repository.check_auth(&request), false); + assert!(!repository.check_auth(&request)); } }